Who wears short shorts?
These shorts are seriously too short.
And, that colour combination is not working either.
At least she isn't wearing heels - she got that much right at least. She's not 14 and she's not a model therefore the very bare minimum 3 inch rule must dictate her relationship with shorts - If the inseam is less than 3 inches: avoid.